ruby on rails - Use multiple database fields to identify users for login -


i'm developing ror application requirement users can log in of 4 possible identifiers: email, home phone #, primary phone #, or work phone #. current solution use regex see if it's correctly formed email address, , if isn't, search users table each of 3 types of phone fields in succession.

# did user try log in email? if is_email params[:session][:login_param]     user = user.find_by(email: params[:session][:login_param].downcase) else    # if login parameter isn't email...     # try finding user home number     user = user.find_by(phone_home: params[:session][:login_param])     if user.nil?         # try finding user cell number         user = user.find_by(phone_cell: params[:session][:login_param])     end     if user.nil?         # try finding user work number         user = user.find_by(phone_work: params[:session][:login_param])     end end # verify password user.authenticate()

my problem has potential search entire users table 3 times if user record near end of table tries logging in work number; don't know if make logins slow in production.

is there cleaner/faster way this?

this should work long validate uniqueness of phone numbers on creation.

class user    def self.find_by_login(login)       where("email = ? or phone_home = ? or phone_cell = ? or phone_work = ?",*([login] * 4)).limit(1)   end end @user = user.find_by_login(params[:session][:login_params]) #this generate following query login_params = 'hello' #=> "select \"users\".* \"users\"  (email = 'hello' or phone_home = 'hello' or phone_cell = 'hello' or phone_work = 'hello')" #authenticate @user

edit

as pointed out original version returned array using added limit(1) return instance of user. mentioned must validate uniqueness each of fields make sure pull correct record.


Comments

Post a Comment

Popular posts from this blog

android - Get AccessToken using signpost OAuth without opening a browser (Two legged Oauth) -

i using signpost oauth access data magento server. have read various tutorials on same , reach point open browser user can enter credentials. however, per requirement have automate part. hence, user should not browser page. have set-up done on server side ( magento ), hit url , returned call page. same through program in android. i have tried below, consumer = new commonshttpoauthconsumer(key, secret); provider = new commonshttpoauthprovider(oauth_init_url,access_token_url, authorize_url); try { provider.retrieverequesttoken(consumer, oauth.out_of_band); log.d("tokens" , consumer.gettoken() + " -- " + consumer.gettokensecret()); } and request tokens. dont know how bypass next step. tried directly accessing accesstoken (stupid of me) provider.retrieveaccesstoken(consumer, "mycallback://callback"); no luck, ends in oauth.signpost.exception.oauthnotauthorizedexception: authorization failed (server replied 401). ...
Read more

org.mockito.exceptions.misusing.InvalidUseOfMatchersException: mockito -

getting error org.mockito.exceptions.misusing.invaliduseofmatchersexception: invalid use of argument matchers! 1 matchers expected, 2 recorded. exception may occur if matchers combined raw values: //incorrect: somemethod(anyobject(), "raw string"); when using matchers, arguments have provided matchers. example: //correct: somemethod(anyobject(), eq("string matcher")); at when( getprogramservice .callservice(any(getprogramtype.class))) .thenreturn(jaxbresponse); please explain error , possible resolution the code posted looks fine; don't see problem it. code before or above causing exception. key here: invalid use of argument matchers! 1 matchers expected, 2 recorded. any , used above, doesn't return "special kind of null" or "special kind of getprogramtype"; don't exist. instead, returns null , side effect puts matcher on stack. whe...
Read more

google shop client API returns 400 bad request error while adding an item -

i'm working on solution add items in google shopping market java application. following tutorial real mess because of missing classes of laste release, after setting 1.5-beta maven managed make base example typecheck correctly classes. still can make simple task of adding 1 item. instead of posting whole code i'm posting part creates product feed. private product createproduct(string id) { product product = new product(); product.title = "red wool sweater"; product.content = new content( "text", "comfortable , soft, sweater keep warm on " + "cold winter nights. red , blue stripes."); product.appcontrol = new appcontrol(); product.appcontrol.addrequireddestination("productads"); product.externalid = id; product.lang = "it"; product.country = "it"; product.condition = "nuovo"; product.price = new price("eu...
Read more