SQL Server 2008R2 Custom Function so slow -


here function:

-- declare @cur cursor declare @line int declare @return varchar(255)  declare mycursor cursor select distinct (quote_ln_no) quote_ln_no   dbo.quote_line_bom  quote_no = @quote_no , component_mat_no = @mat_no order quote_ln_no  set @return = ''  open mycursor  fetch next mycursor @line while @@fetch_status = 0 begin   set @return = @return + convert(varchar, @line) + ', '   fetch next mycursor    @line end  close mycursor deallocate mycursor   if len(@return) > 0  set @return = substring(@return, 1, len(@return)-1)  return @return

when use function in query returns on 3000 records, function adds 20 seconds.

please let me know wrong or there way make run faster?

i think faster. it's set-based , doesn't use cursor.

declare @return varchar(255) = ''  select @return = @return + cast(quote_ln_no varchar) + ',' dbo.quote_line_bom quote_no = @quote_no , component_mat_no = @mat_no , quote_ln_no not null group quote_ln_no order quote_ln_no  if len(@return) > 0      set @return = substring(@return, 1, len(@return)-1)  select @return  --this user defined function, right? --return @return

Comments

Post a Comment

Popular posts from this blog

android - Get AccessToken using signpost OAuth without opening a browser (Two legged Oauth) -

i using signpost oauth access data magento server. have read various tutorials on same , reach point open browser user can enter credentials. however, per requirement have automate part. hence, user should not browser page. have set-up done on server side ( magento ), hit url , returned call page. same through program in android. i have tried below, consumer = new commonshttpoauthconsumer(key, secret); provider = new commonshttpoauthprovider(oauth_init_url,access_token_url, authorize_url); try { provider.retrieverequesttoken(consumer, oauth.out_of_band); log.d("tokens" , consumer.gettoken() + " -- " + consumer.gettokensecret()); } and request tokens. dont know how bypass next step. tried directly accessing accesstoken (stupid of me) provider.retrieveaccesstoken(consumer, "mycallback://callback"); no luck, ends in oauth.signpost.exception.oauthnotauthorizedexception: authorization failed (server replied 401). ...
Read more

org.mockito.exceptions.misusing.InvalidUseOfMatchersException: mockito -

getting error org.mockito.exceptions.misusing.invaliduseofmatchersexception: invalid use of argument matchers! 1 matchers expected, 2 recorded. exception may occur if matchers combined raw values: //incorrect: somemethod(anyobject(), "raw string"); when using matchers, arguments have provided matchers. example: //correct: somemethod(anyobject(), eq("string matcher")); at when( getprogramservice .callservice(any(getprogramtype.class))) .thenreturn(jaxbresponse); please explain error , possible resolution the code posted looks fine; don't see problem it. code before or above causing exception. key here: invalid use of argument matchers! 1 matchers expected, 2 recorded. any , used above, doesn't return "special kind of null" or "special kind of getprogramtype"; don't exist. instead, returns null , side effect puts matcher on stack. whe...
Read more

google shop client API returns 400 bad request error while adding an item -

i'm working on solution add items in google shopping market java application. following tutorial real mess because of missing classes of laste release, after setting 1.5-beta maven managed make base example typecheck correctly classes. still can make simple task of adding 1 item. instead of posting whole code i'm posting part creates product feed. private product createproduct(string id) { product product = new product(); product.title = "red wool sweater"; product.content = new content( "text", "comfortable , soft, sweater keep warm on " + "cold winter nights. red , blue stripes."); product.appcontrol = new appcontrol(); product.appcontrol.addrequireddestination("productads"); product.externalid = id; product.lang = "it"; product.country = "it"; product.condition = "nuovo"; product.price = new price("eu...
Read more