android - Why is my button doing nothing? -

probably basic mistake i'm working on adding additional features random open source project found on web part of learning work android , add additional activities. code follows, taking out irrelevant bits:

import mun.pakkaus.aateekoo.r; import android.app.activity; import android.content.intent; import android.os.bundle; import android.view.view; import android.view.view.onclicklistener; import android.widget.adapterview; import android.widget.adapterview.onitemselectedlistener; import android.widget.arrayadapter; import android.widget.button; import android.widget.edittext; import android.widget.spinner; import android.widget.textview; import android.util.log;   public class caloriecounter extends activity  {     string gda;     edittext tx, weighte, heighte, agee;     textview counter;     spinner spin;     string gender;      /** called when activity first created. */     @override     public void oncreate(bundle savedinstancestate)      {         super.oncreate(savedinstancestate);         setcontentview(r.layout.main);         button button2 = (button) findviewbyid(r.id.button2);     }      public onclicklistener button2 = new onclicklistener()     {         public void onclick(view arg0)          {             intent nextscreen = new intent(getapplicationcontext(),                     secondscreenactivity.class);             nextscreen.putextra("gender", gender);             log.e("n", gender);             startactivity(nextscreen);         }     }; } 

and second activity is:

package my.pack.coursework; import mun.pakkaus.aateekoo.*; import android.app.activity; import android.content.intent; import android.os.bundle; import android.util.log; import android.view.view; import android.widget.button; import android.widget.edittext; import android.widget.textview;  public class secondscreenactivity extends activity  {     public void oncreate(bundle savedinstancestate)     {         super.oncreate(savedinstancestate);         setcontentview(r.layout.screen2);          button button1 = (button) findviewbyid(r.id.button1);          button1.setonclicklistener(new view.onclicklistener()              {                 public void onclick(view arg0)                  {                     textview counter;                     intent = getintent();                     string gender = i.getstringextra("gender");                     log.e("second screen", gender + ".");                     counter = (textview) findviewbyid(r.id.textview23);                     int caloriesburned = 0; int caloriesconsumed = 0;                     edittext consumede;                     edittext burnede;                     string test1, test2;                     test1 = getstring(r.id.txtburned);                     test2 = getstring(r.id.txtconsumed);                     try                      {                         if (test1 != "" && test2 != "")                          {                             burnede = (edittext) findviewbyid(r.id.txtburned);                             caloriesburned = integer.parseint(burnede.gettext().tostring().trim());                             consumede = (edittext) findviewbyid(r.id.txtconsumed);                             caloriesconsumed = integer.parseint(consumede.gettext().tostring().trim());                              if(gender.contains("male") && caloriesconsumed - caloriesburned > 2000)                             {                                 counter.settext("you on gda of calories");                             }                             else                             {                                 counter.settext("don't add offensive text");                             }                         }                     }                     catch (exception e)                      {                         system.out.println(e);                     }                 }             });     } } 

essentially, why activity not switching?

you have created button locally destroyed after oncreate(). declare globally in class , initialize in oncreate().

button button2;   oncreate() {     button2 = (button) findviewbyid(r.id.button2);     button2.setonclicklistener(this); }  public void onclick(view v)  {     if(v == button2)      {      } }